-
-
Notifications
You must be signed in to change notification settings - Fork 617
refactor: replace deprecated use of vim.diagnostic.is_disabled() #2781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace deprecated use of vim.diagnostic.is_disabled() #2781
Conversation
Thank you, we do need to retain compatibility. Those tests work - has 0.10 will still be true for 0.11... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Many thanks for your contribution!
Now that 0.10 is released we can start on #2731 - any assistance on that would be most gratefully appreciated. That will allow us to pick up on these sorts of issues.
This gives me an error that
|
Let's revert this one. It looks like it's not present in older 0.10 builds, which people do actively use. |
Reverted in #2784 |
We need some other implementation of that check then as it affects users on new enough versions. |
Yes. Now that stable is 0.10 we should add 0.9 back to the matrix. The 0.10 dev versions are a problem; API broke many times. Edit: we might be able to test for pre-release: |
Fortunately, API levels have been implemented and are available since 0.9 We'll need to increase the minimum supported version to 0.9. Unfortunately we're not going to get any value out of CI as 0.9 lacks the API symbols. |
According to Neovims Release news in the newly released v.0.10
vim.diagnostic.is_disabled()
is deprecated in favor ofvim.diagnostic.is_enabled()
.I wasn't sure if there should be backwards compatibility left in for v0.9 or not. I'm not very solid with Lua, so I don't know if that
if/else
makes sense to 'solve' backwards compatibility.